-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pageserver): generate basebackup from aux file v2 storage #7517
Conversation
3042 tests run: 2915 passed, 0 failed, 127 skipped (full report)Flaky tests (4)Postgres 16
Postgres 15
Postgres 14Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
801550e at 2024-05-07T16:38:45.689Z :recycle: |
dbe3d95
to
06c3377
Compare
d3500b4
to
70e6c81
Compare
70e6c81
to
3e784c7
Compare
All failed tests pass locally so I assume it's something wrong with vectored get env variable in CI. Fix in #7569. |
4229426
to
5d9ba8b
Compare
dd0a2fa
to
48907cb
Compare
rebased to the new scan implementation pull request and added aux_file_v2 test matrix for regress tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The looks good to me, but I have questions about the testing.
Assuming a bug with aux files v2, I don't think there is a guarantee that postgress will generate an error. Have you considered validating the two aux files implementations against each other (at least in the tests)?
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Added a new cross-validation mode to aux file policy flag, waiting for CI runs. |
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
added 26efd47 to fix a bug on the code path of using vectored get for sequential get. It should throw a missing key error, but it doesn't. Think about the case if a key does not exist. In the code path, we will create a ValueReconstructState of empty image and empty WAL, which then gets passed to Therefore, if the cached image is not found, we do not add it to the value reconstruct state to avoid calling into reconstruct_value.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few nits.
Signed-off-by: Alex Chi Z <chi@neon.tech>
Signed-off-by: Alex Chi Z <chi@neon.tech>
This pull request adds the new basebackup read path + aux file write path. In the regression test, all logical replication tests are run with matrix aux_file_v2=false/true. Also fixed the vectored get code path to correctly return missing key error when being called from the unified sequential get code path. --------- Signed-off-by: Alex Chi Z <chi@neon.tech>
Problem
This pull request adds the new basebackup read path + aux file write path. In the regression test, all logical replication tests are run with matrix aux_file_v2=false/true.
Summary of changes
Checklist before requesting a review
Checklist before merging