-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pageserver): properly propagate missing key error for vectored get #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chi Z <chi@neon.tech>
2856 tests run: 2735 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
0f98799 at 2024-05-01T17:04:05.773Z :recycle: |
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/propagate-missing-key
branch
from
April 30, 2024 21:24
55c9ec1
to
4f35c31
Compare
5 tasks
Signed-off-by: Alex Chi Z <chi@neon.tech>
VladLazar
reviewed
May 1, 2024
removed stuck_at_lsn and vectored_get field, maybe we will add a key_range field in the future, but for now, not adding it to avoid large copies (keyspace can be large with multiple partitions). |
Signed-off-by: Alex Chi Z <chi@neon.tech>
skyzh
force-pushed
the
skyzh/propagate-missing-key
branch
from
May 1, 2024 16:20
a0bf19e
to
0f98799
Compare
VladLazar
approved these changes
May 1, 2024
conradludgate
pushed a commit
that referenced
this pull request
May 8, 2024
#7569) Some part of the code requires missing key error to be propagated to the code path correctly (i.e., aux key range scan). Currently, it's an anyhow error. * remove `stuck_lsn` from the missing key error. * as a result, when matching missing key, we do not distinguish the case `stuck_lsn = false/true`. * vectored get now use the unified missing key error. --------- Signed-off-by: Alex Chi Z <chi@neon.tech>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some part of the code requires missing key error to be propagated to the code path correctly (i.e., aux key range scan). Currently, it's an anyhow error.
stuck_lsn
from the missing key error.stuck_lsn = false/true
.Summary of changes
Checklist before requesting a review
Checklist before merging