Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Another iteration on making walcraft more robust #7588

Merged
merged 2 commits into from
May 22, 2024
Merged

Another iteration on making walcraft more robust #7588

merged 2 commits into from
May 22, 2024

Conversation

arssher
Copy link
Contributor

@arssher arssher commented May 2, 2024

No description provided.

@arssher arssher requested a review from hlinnaka May 2, 2024 12:56
@arssher arssher requested review from a team as code owners May 2, 2024 12:56
@arssher arssher requested a review from petuhovskiy May 2, 2024 12:56
@arssher
Fix typo in pr #7439.
2cb955f
@arssher
One more iteration on making walcraft test more robust.
156d776 
Some WAL might be inserted on the page boundary before XLOG_SWITCH lands there,
repeat construction in this case.
@arssher arssher mentioned this pull request May 2, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

2862 tests run: 2741 passed, 0 failed, 121 skipped (full report)

Flaky tests (2)

Postgres 15

  • test_partial_evict_tenant[relative_spare]: release
  • test_download_remote_layers_api: release

Code coverage* (full report)

  • functions: 28.0% (6601 of 23539 functions)
  • lines: 46.7% (46870 of 100356 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
156d776 at 2024-05-02T13:39:33.878Z :recycle:

hlinnaka
hlinnaka approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, the point is to make this robust if something else inserts WAL while we're doing this, which would screw up the calculation.

libs/postgres_ffi/wal_craft/src/lib.rs Show resolved Hide resolved
@arssher arssher merged commit b43f6da into main May 22, 2024
53 checks passed
@arssher arssher deleted the walcraft-typ branch May 22, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlinnaka hlinnaka hlinnaka approved these changes

@petuhovskiy petuhovskiy Awaiting requested review from petuhovskiy petuhovskiy is a code owner automatically assigned from neondatabase/safekeepers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arssher @hlinnaka