Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_crafted_wal_end flakyness #4691

Closed
koivunej opened this issue Jul 12, 2023 · 8 comments
Closed

test_crafted_wal_end flakyness #4691

koivunej opened this issue Jul 12, 2023 · 8 comments
Assignees
Labels
a/test/flaky Area: related to flaky tests c/storage/safekeeper Component: storage: safekeeper

Comments

@koivunej
Copy link
Member

koivunej commented Jul 12, 2023

The test_crafted_wal_end has been flaky in a number of ways. This issue tracks all findings.

test_crafted_wal_end[release-pg15-last_wal_record_xlog_switch_ends_on_page_boundary]: release

@koivunej koivunej added the a/test/flaky Area: related to flaky tests label Jul 12, 2023
@koivunej
Copy link
Member Author

koivunej commented Jul 14, 2023

test_crafted_wal_end[debug-pg15-last_wal_record_crossing_segment]: debug

@koivunej
Copy link
Member Author

test_crafted_wal_end[debug-pg15-wal_record_crossing_segment_followed_by_small_one]: debug

@jcsp
Copy link
Collaborator

jcsp commented Aug 3, 2023

https://github.com/neondatabase/neon/actions/runs/5752601432/job/15594169701?pr=4890

 FAILED test_runner/regress/test_crafted_wal_end.py::test_crafted_wal_end[release-pg15-last_wal_record_xlog_switch_ends_on_page_boundary] - RuntimeError:             Run ['/tmp/neon/bin/wal_craft', 'in-existing', 'last_wal_record_xlog_switch_ends_on_page_boundary', "host=localhost port=29015 user=cloud_admin dbname=postgres options='-cstatement_timeout=120s '"] failed:
              stdout: 
              stderr: [2023-08-03T15:27:26Z INFO  wal_craft] current_wal_insert_lsn=0/14F51F8, remaining_lsn=11784, base_wal_advance=8368, repeats=3426

@awestover
Copy link
Contributor

could this be the same not flushing xlog problem as from #559 ?

@awestover
Copy link
Contributor

awestover commented Aug 4, 2023

John's Allure report had this in it:

2023-08-03T17:41:47.279783Z  INFO http request{otel.name=/extension_server/neon_test_utils http.method=POST}: serving /extension_server POST request, filename: "neon_test_utils" is_library: false
2023-08-03T17:41:47.279892Z ERROR http request{otel.name=/extension_server/neon_test_utils http.method=POST}: extension download failed: No remote extension storage

really hope it's unrelated to the test failure
but if it was, I think I wrote a patch to fix it

@arssher arssher self-assigned this Feb 9, 2024
@arssher arssher added the c/storage/safekeeper Component: storage: safekeeper label Mar 14, 2024
arssher added a commit that referenced this issue Mar 15, 2024
Postgres can always write some more WAL, so previous checks that WAL doesn't
change after something had been crafted were wrong; remove them. Add comments
here and there.

should fix #4691
arssher added a commit that referenced this issue Mar 19, 2024
Postgres can always write some more WAL, so previous checks that WAL doesn't
change after something had been crafted were wrong; remove them. Add comments
here and there.

should fix #4691
@jcsp
Copy link
Collaborator

jcsp commented May 2, 2024

@arssher can you look at recent failures of this test and see if it is the same issue as this ticket?

@arssher
Copy link
Contributor

arssher commented May 2, 2024

@arssher
Copy link
Contributor

arssher commented May 2, 2024

#7592 is for the slack thread in the previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a/test/flaky Area: related to flaky tests c/storage/safekeeper Component: storage: safekeeper
Projects
None yet
Development

No branches or pull requests

4 participants