Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid creation of child timelines of archived timeline #9122

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Sep 24, 2024

We don't want to allow any new child timelines of archived timelines. If you want any new child timelines, you should first un-archive the timeline.

Part of #8088

@arpad-m arpad-m requested a review from a team as a code owner September 24, 2024 11:59
@arpad-m arpad-m requested a review from jcsp September 24, 2024 11:59
Copy link

github-actions bot commented Sep 24, 2024

5038 tests run: 4874 passed, 0 failed, 164 skipped (full report)


Flaky tests (10)

Postgres 17

Postgres 16

Postgres 15

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Postgres 14

  • test_ondemand_wal_download_in_replication_slot_funcs: release-x86-64

Code coverage* (full report)

  • functions: 32.2% (7473 of 23243 functions)
  • lines: 50.0% (60228 of 120515 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
adab332 at 2024-09-25T21:46:24.409Z :recycle:

@arpad-m arpad-m requested a review from skyzh September 25, 2024 19:02
pageserver/src/tenant.rs Show resolved Hide resolved
@skyzh
Copy link
Member

skyzh commented Sep 25, 2024

LGTM :)

@arpad-m arpad-m merged commit 7bae781 into main Sep 26, 2024
80 checks passed
@arpad-m arpad-m deleted the arpad/no_new_children_of_archived branch September 26, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants