Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VV/EE Create and apply icon font seAp #24

Closed
6 tasks done
Nikomus opened this issue Nov 18, 2019 · 15 comments · Fixed by #36
Closed
6 tasks done

VV/EE Create and apply icon font seAp #24

Nikomus opened this issue Nov 18, 2019 · 15 comments · Fixed by #36
Assignees

Comments

@Nikomus
Copy link
Contributor

Nikomus commented Nov 18, 2019

Description

Plan

  • Generate icon fonts similar to those for Haven and Hospice Hope but relevant for seAp using Icomoon
  • Add icons
  • Acknowledge source of icons with comments in icons stylesheet

Acceptance Criteria

  • icons exist and are used
  • @roseb04 to check icons chosen and approve their use
  • [dev] source(s) is/are acknowledged
@rosejbon rosejbon added this to the October Sprint 2019 milestone Dec 6, 2019
@rosejbon
Copy link
Contributor

I think we will need @HedgehogHolly to help with this issue, she is on holiday but back tomorrow

@HedgehogHolly
Copy link

What specifically do you want me to help with @roseb04?

@rosejbon
Copy link
Contributor

rosejbon commented Dec 19, 2019 via email

@HedgehogHolly
Copy link

HedgehogHolly commented Dec 19, 2019

seAp didn't have any icons themselves, the ones on the designs are left over from Samaritans design I think (sorry!). So new ones will need to be picked, do you know what the info sections will be @roseb04?

@Nikomus are you suggesting we use fontawesome? or making our own font from icons id make?

@rosejbon
Copy link
Contributor

@HedgehogHolly what icons would you think could go with these questions:

  1. What happens when you contact us?
  2. What can I expect?
  3. Will I be harming the NHS?
  4. Am I just making a fuss?
  5. Will I be treated differently if I complain?
  6. Is complaining a lot of work?

@rosejbon rosejbon removed the Blocked label Jan 7, 2020
@rosejbon
Copy link
Contributor

rosejbon commented Jan 7, 2020

We are going to use the icon fonts from Haven and Hospice Hope, if any concerns over what icons to use then chat with me :)

@katjam
Copy link
Contributor

katjam commented Jan 16, 2020

@AlinChindea The plan and AC here need updating to match the work done. Add one criteria for @roseb04 to check the icons we chose.

@jermyk
Copy link

jermyk commented Jan 22, 2020

@AlinChindea
Re the AC #1 - "icons exist and are used", how does one know which are the correct icons displayed?

@AlinChindea
Copy link
Contributor

@AlinChindea
Re the AC #1 - "icons exist and are used", how does one know which are the correct icons displayed?

@jermyk I will update the copy doc with the icons used and you can compare the name with the spreadsheet info and just confirm that icons are visible. @roseb04 should check the icons chosen - 2nd criterion in the list

@rosejbon
Copy link
Contributor

@jermyk we can check off the second one, I am happy with the icons choosen

@rosejbon rosejbon mentioned this issue Jan 22, 2020
8 tasks
@jermyk
Copy link

jermyk commented Jan 28, 2020

Acceptance Criteria

  • icons exist and are used
  • @roseb04 to check icons chosen and approve their use
  • source(s) is/are acknowledged
    Untitled_Clipping_013020_043012_PM

@jermyk
Copy link

jermyk commented Jan 28, 2020

@AlinChindea Can you explain what AC no. 3 means please?

@jermyk
Copy link

jermyk commented Jan 28, 2020

  1. What happens when you contact us?
  2. What can I expect?
  3. Will I be harming the NHS?
  4. Am I just making a fuss?
  5. Will I be treated differently if I complain?
  6. Is complaining a lot of work?

Screenshot_012820_042648_PM

@AlinChindea
Copy link
Contributor

@AlinChindea Can you explain what AC no. 3 means please?

@jermyk You can check that in the developer tools - head tag, and it will be one of the <style type="type/css">...</style> tags. See below - in this case, are the rows in light green starting with /*
Screenshot from 2020-01-30 16-13-01

@jermyk jermyk self-assigned this Jan 30, 2020
@jermyk
Copy link

jermyk commented Feb 11, 2020

  • AC no.3 Screenshot 2020-02-11 at 11 03 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants