Sbt migration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prassee could you retain pom.xml? since someone might be get used to maven. |
|
ok I will put pom.xml back.. are the SBT changes good to go? |
|
travis ci accepts your changes, I think building should have no problem. one more question, do you check coverage report is generated as expected? to make sure we do not break coveralls report. |
|
yes the coverage report gets generated and I have added coverall sbt plugin to the travis build. |
neoremind
approved these changes
Aug 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates maven build to sbt build.
I have also renamed kraps-rpc as kraps-core.