BUGFIX: Recursively allow all properties when converting events #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with nested value objects where a fixed hierarchy for a property mapping configuration does not work.
bwaidelich
reviewed
Sep 22, 2017
| $configuration = new PropertyMappingConfiguration(); | ||
| $configuration->allowAllProperties(); | ||
| $configuration->forProperty('*')->allowAllProperties(); | ||
| $configuration = new AllowAllPropertiesPropertyMappingConfiguration(); |
There was a problem hiding this comment.
Ah, I like that!
So much that I would even imagine this to be part of Flow!?
So much even, that I could imagine some special syntax like
$this->propertyMapper->forceConvert($source, $targetType);(but that could be a separate step ofc)
There was a problem hiding this comment.
Yes! Let's have a separate PR for that.
bwaidelich
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues with nested value objects where a fixed hierarchy
for a property mapping configuration does not work.