Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature counter raises an error when numbers contain commas or dots #327

Closed
Sebobo opened this issue Jan 28, 2020 · 1 comment
Closed

Feature counter raises an error when numbers contain commas or dots #327

Sebobo opened this issue Jan 28, 2020 · 1 comment
Labels
bug

Comments

@Sebobo
Copy link
Member

Sebobo commented Jan 28, 2020

This can be reproduced on case study pages when entering a comma into a large number.
Then also the images won't load because of the error.

In general errors in components shouldn't prevent all components from loading.
@Sebobo Sebobo added the bug label Jan 28, 2020
@regniets regniets mentioned this issue Oct 2, 2020
Merged
@regniets
Copy link
Contributor

regniets commented Oct 2, 2020

Had this issue recently and just found your issue.
I would suggest solving it by leveraging validtion in the ui.

regniets added a commit that referenced this issue Oct 5, 2020
@regniets
Merge pull request #363 from regniets/bugfix/countup
c768c66 
Added Validators to countup, solves issue #327
@regniets regniets closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sebobo @regniets