BUGFIX: Searching for " does not break search #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now a search for " breaks the search. This change removes " from the search term, to fix that. As far as I found out, it is the only character breaking the search.
daniellienert
approved these changes
Apr 28, 2020
|
technically a pair of quotes is fine and even useful in a search 🤷 so ideally we would filter non paired quotes only? I guess fine for a bugfix for now... |
robertlemke
approved these changes
Apr 28, 2020
Well, the Marketplace code wraps the search string in |
|
True @kdambekalns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now a search for " breaks the search. This change removes " from
the search term, to fix that. As far as I found out, it is the only
character breaking the search.