BUGFIX: Output capturing for console respects the diable output setting #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is indeed a regression from 1fdf97b, so could we please merge this? Regarding the TODO and table output: ideally we could inject a different |
hlubek
added a commit
to hlubek/behat
that referenced
this pull request
Oct 16, 2020
If a command is run and throws an exception it must not be catched. Better use `finally` to just make sure output is enabled (which is always enabled anyway until neos#19 is merged).
albe
approved these changes
Mar 14, 2021
There was a problem hiding this comment.
Indeed a boolean swap regression! Thanks a lot for finding and submitting this patch!
Regarding the TODO and table output: ideally we could inject a different output instance in ConsoleOutput that captures all console output, so everything "just works" without advicing lots of different methods.
That would be cool, so if anyone is up for digging into that, feel free to submit a PR and tag me for review!
albe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tables where not captured and always printed to the console.