Merge pull request #999 from albe/scalar-typehints-utility-lock

!!!TASK: Add PHP 7.0 scalar type hints to method arguments and return types This is only breaking for classes implementing `LockStrategyInterface`, whose signature now requires scalar typehints.
neos · Dec 27, 2017 · c2211b6 · c2211b6
2 parents 0885d3e + 0f99a35
commit c2211b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/Neos.Utility.Lock/Classes/FlockLockStrategy.php b/Neos.Utility.Lock/Classes/FlockLockStrategy.php
@@ -67,7 +67,7 @@ public function __construct(array $options = [])
      * @return void
      * @throws LockNotAcquiredException
      */
-    public function acquire($subject, $exclusiveLock)
+    public function acquire(string $subject, bool $exclusiveLock)
     {
         $this->lockFileName = Utility\Files::concatenatePaths([$this->temporaryDirectory, md5($subject)]);
         $aquiredLock = false;

diff --git a/Neos.Utility.Lock/Classes/LockStrategyInterface.php b/Neos.Utility.Lock/Classes/LockStrategyInterface.php
@@ -23,10 +23,10 @@ interface LockStrategyInterface
      * @param boolean $exclusiveLock TRUE to, acquire an exclusive (write) lock, FALSE for a shared (read) lock.
      * @return void
      */
-    public function acquire($subject, $exclusiveLock);
+    public function acquire(string $subject, bool $exclusiveLock);
 
     /**
      * @return boolean TRUE on success, FALSE otherwise
      */
-    public function release();
+    public function release(): bool;
 }