!!!TASK: Add PHP 7.0 scalar type hints to method arguments and return types #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@albe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kdambekalns, @kitsunet and @radmiraal to be potential reviewers. |
albe
changed the title
kdambekalns
approved these changes
Jul 19, 2017
| @@ -132,7 +132,7 @@ protected function tryToAcquireLock($exclusiveLock) | |||
| * @param boolean $exclusiveLock | |||
| * @throws LockNotAcquiredException | |||
| */ | |||
| protected function applyFlock($exclusiveLock) | |||
| protected function applyFlock(bool $exclusiveLock) | |||
There was a problem hiding this comment.
While we are at it, and since void as return type is only supported in PHP 7.1, why not add the missing @return annotation here? ;)
|
I was thinking of doing a b/c version of this and the other PR if I still get it done before the release. That way we hopefully have "as much as possible typehinting" in the release without breaking stuff and can then add breaking typehint in interfaces and possibly even strict_types for next major |
This was referenced Jul 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only breaking for classes implementing
LockStrategyInterface, whose signature now requires scalar typehints.