cannot build interceptor code for private method BrowserState::initializeData()

[kdambekalns]

Description

Updated a new Neos instance (Neos 5.3.0 and Flow 6.3.1 => 6.3.2) and ran ./flow package: rescan. Get the following error.

The Neos\Flow\Aop\Builder\AdvicedMethodInterceptorBuilder cannot build interceptor code for private method Neos\Media\Browser\Domain\Session\BrowserState::initializeData().
Please change the scope to at least protected or adjust the pointcut
expression in the corresponding aspect.
  Type: Neos\Flow\Aop\Exception
  Code: 1593070574
  File:
Packages/Framework/Neos.Flow/Classes/Aop/Builder/AdvicedMethodInterceptorBu
        ilder.php
  Line: 42
Open Data/Logs/Exceptions/20201029091519918cd4.txt for a full stack
trace.
  Type: Neos\Flow\Core\Booting\Exception\SubProcessException
  Code: 1355480641
  File: Packages/Framework/Neos.Flow/Classes/Core/Booting/Scripts.php
  Line: 699
Open Data/Logs/Exceptions/20201029091518caed70.txt for a full stack trace.

Affected Versions

Neos: 5.3.0

Flow: 6.3.2

[kdambekalns]

Related to #2131 (BUGFIX: Disallow advising of private methods)

[kdambekalns]

Put this in Neos, as it is exposed by a Flow change, but seems to originate in Neos.Media…

[patriceckhart]

Exception #1355480641 in line 384 of /data/neos/Packages/Framework/Neos.Flow/Classes/Core/Booting/Scripts.php: The Neos\Flow\Aop\Builder\AdvicedMethodInterceptorBuilder cannot build interceptor code for private method Neos\Media\Browser\Domain\Session\BrowserState::initializeData().
Please change the scope to at least protected or adjust the pointcut
expression in the corresponding aspect.

  Type: Neos\Flow\Aop\Exception
  Code: 1593070574
  File: Packages/Framework/Neos.Flow/Classes/Aop/Builder/AdvicedMethodInterceptorBu
        ilder.php
  Line: 42

Open Data/Logs/Exceptions/20201029091519918cd4.txt for a full stack trace.

13 Neos\Flow\Core\Booting\Scripts::executeCommand("neos.flow:core:compile", array|16|)
12 Neos\Flow\Core\Booting\Scripts::initializeProxyClasses(Neos\Flow\Core\Bootstrap)
11 call_user_func(array|2|, Neos\Flow\Core\Bootstrap)
10 Neos\Flow\Core\Booting\Step::__invoke(Neos\Flow\Core\Bootstrap)
9 Neos\Flow\Core\Booting\Sequence::invokeStep(Neos\Flow\Core\Booting\Step, Neos\Flow\Core\Bootstrap)
8 Neos\Flow\Core\Booting\Sequence::invokeStep(Neos\Flow\Core\Booting\Step, Neos\Flow\Core\Bootstrap)
7 Neos\Flow\Core\Booting\Sequence::invokeStep(Neos\Flow\Core\Booting\Step, Neos\Flow\Core\Bootstrap)
6 Neos\Flow\Core\Booting\Sequence::invokeStep(Neos\Flow\Core\Booting\Step, Neos\Flow\Core\Bootstrap)
5 Neos\Flow\Core\Booting\Sequence::invoke(Neos\Flow\Core\Bootstrap)
4 Neos\Flow\Cli\CommandRequestHandler::boot("Runtime")
3 Neos\Flow\Cli\CommandRequestHandler::handleRequest()
2 Neos\Flow\Core\Bootstrap::run()
1 require("/data/neos/Packages/Framework/Neos.Flow/Scripts/flow.php")

[kdambekalns]

Thanks for the trace! But as I feared, not helpful. 😞

[albe]

Yeah, we need to find the aspect that targets this class. The expression is probably too loose and accidentially targets the initializeData method. If targeting this method is intended, then this is a bug uncovered.

Edit: Can't find anything in Neos.Media and Neos.Media.Browser - so another package that AOPs the Media Browser?

[bwaidelich]

The stack trace helped me a little :)
I think it's the SessionObjectMethodsPointcutFilter of Flow that targets the method. Investigating why that is...

[bwaidelich]

OK, it's because we include private methods in

flow-development-collection/Neos.Flow/Classes/Session/Aspect/SessionObjectMethodsPointcutFilter.php

Lines 50 to 70 in e13e76d

	public function matches($className, $methodName, $methodDeclaringClassName, $pointcutQueryIdentifier)
	{
	if ($methodName === null) {
	return false;
	}
	$objectName = $this->objectManager->getObjectNameByClassName($className);
	if (empty($objectName)) {
	return false;
	}
	if ($this->objectManager->getScope($objectName) !== ObjectConfiguration::SCOPE_SESSION) {
	return false;
	}
	if (preg_match('/^__wakeup|__construct|__destruct|__sleep|__serialize|__unserialize|__clone|shutdownObject|initializeObject|inject.*$/', $methodName) !== 0) {
	return false;
	}
	return true;
	}

[bwaidelich]

Adding some

        if (!is_callable([$className, $methodName])) {
            return false;
        }

there seems to do the trick but I'm not sure if that's the best way to go

[kdambekalns]

That being said, in

flow-development-collection/Neos.Flow/Classes/Session/Aspect/SessionObjectMethodsPointcutFilter.php

Line 65 in d291ccf

if (preg_match('/^__wakeup|__construct|__destruct|__sleep|__serialize|__unserialize|__clone|shutdownObject|initializeObject|inject.*$/', $methodName) !== 0) {

the expression should be ^(?:__wakeup|__construct|__destruct|__sleep|__serialize|__unserialize|__clone|shutdownObject|initializeObject|inject.*)$ (added grouping), to make ^ and $ work with all alternatives!

[kdambekalns]

It's in Flow, after all, so I moved the issue.

[bwaidelich]

..good call (both)

[albe]

Adding some

        if (!is_callable([$className, $methodName])) {
            return false;
        }

there seems to do the trick but I'm not sure if that's the best way to go

is_callable checks callability from current scope, right? But what about protected methods?

[bwaidelich]

is_callable checks callability from current scope, right? But what about protected methods?

good point.. maybe check for private scope explicitly

[bwaidelich]

@kdambekalns @albe This issue is assigned to the three of us for some reason.
Is one of you working on a fix? Because I'm currently not, but I could have a look tomorrow if nobody takes care of it before that

[kdambekalns]

I assigned it to us, since we discussed it this morning. Didn't @kitsunet mention he might be able to look into it?

[kdambekalns]

I'll work on this now.