BUGFIX: AnnotationDriver correctly applies ORM relation annotations #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@albe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skurfuerst, @kdambekalns and @bwaidelich to be potential reviewers. |
albe
force-pushed
the
annotationdriver-fix
branch
from
9d7693c
to
6876dce
Compare
Before any `falsy` value in one of the ORM relation annotations, like e.g.
`orphanRemoval=false` or `cascade={}`, would not be applied to mapping
and hence the defaults still be in effect.
This change fixes that by explicitly checking the annotation properties
against null, so that any value specified by the user will actually be applied.
albe
force-pushed
the
annotationdriver-fix
branch
from
6876dce
to
f8f7485
Compare
kitsunet
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before any
falsyvalue in one of the ORM relation annotations, like e.g.orphanRemoval=falseorcascade={}, would not be applied to mapping and hence the defaults still be in effect. This change fixes that by explicitly checking the annotation properties against null, so that any value specified by the user will actually be applied.Fixes #1079