TASK: Use RouterInterface instead of concrete implementation #1228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
requested changes
Mar 7, 2018
| @@ -37,7 +37,7 @@ class RoutingCommandController extends CommandController | |||
|
|
|||
| /** | |||
| * @Flow\Inject | |||
| * @var Router | |||
| * @var RouterInterface | |||
There was a problem hiding this comment.
The RoutingCommandController invokes methods on the router that are not part of the interface, namely getRoutes()
| @@ -49,7 +49,7 @@ class InternalRequestEngine implements RequestEngineInterface | |||
|
|
|||
| /** | |||
| * @Flow\Inject(lazy = false) | |||
| * @var Router | |||
| * @var RouterInterface | |||
| */ | |||
| protected $router; | |||
There was a problem hiding this comment.
You didn't adjust the return type hint of the respective getter (https://github.com/Torsten85/flow-development-collection/blob/39e601e0312fe5bc3a8ef0e9f4a937063e3cda4d/Neos.Flow/Classes/Http/Client/InternalRequestEngine.php#L138)
There was a problem hiding this comment.
Sorry for that, was a bit in a hurry ;)
| @@ -292,6 +292,9 @@ Neos\Flow\Property\PropertyMapper: | |||
| # ResourceManagement # | |||
| # # | |||
|
|
|||
| Neos\Flow\Mvc\Routing\RouterInterface: | |||
| className: Neos\Flow\Mvc\Routing\Router | |||
|
|
|||
There was a problem hiding this comment.
You changed this in the section "ResourceManagement", There is already one for "MVC"
|
Makes sense in general, but there are some minor issues with the current change |
bwaidelich
approved these changes
Mar 7, 2018
johannessteu
approved these changes
Mar 8, 2018
ComiR
pushed a commit
to ComiR/flow-development-collection
that referenced
this pull request
Aug 17, 2018
TASK: Use RouterInterface instead of concrete implementation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the concrete
RouterImplementation is used instead of the more flexibleRouterInterface.This PR ensures the
RouterInterfaceis used.