BUGFIX: Render debugger-styles directly with first debug-output #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The styles for rendering the debug-output are now rendered with the first output itself instead of being echoed. The direct echo solution caused trouble whenever non html-data like json was rendered because the styles were rendered outside the json-structure.
mficzel
changed the title
|
Yes, love it! |
beheist
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The styles for rendering the debug-output are now rendered with the
first output itself instead of being echoed.
The direct echo solution caused trouble whenever non html-data like
json was rendered because the styles were rendered outside the json-structure
and thus caused invalid json.