[BUGFIX] Roles are refreshed after setting authentication status #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As soon as an authentication process completes, roles might have changed. Therefore we have to reinitialize the roles first level cache in the security context.
foerthner
force-pushed
the
roles-first-level-cache-fix-2.3
branch
from
932db6f
to
3a12fc8
Compare
|
👍 by reading, although not deep into the subject |
|
Makes sense and should have no side-effects, 👍 by reading |
|
👍 by reading |
|
👍 by reading. |
|
FYI: I also tested this patch, verifying that it doesn't break an existing application. However I couldn't reproduce the bug - it probably only occurs with multiple concurring authentication tokens |
foerthner
added a commit
that referenced
this pull request
Nov 25, 2015
[BUGFIX] Roles are refreshed after setting authentication status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise getRoles() might act on the wrong value of the overall
authentication status stored in the authentication manager.