Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Only add type hint if not already present #1370

Merged
merged 1 commit into from
Aug 22, 2018
Merged

BUGFIX: Only add type hint if not already present #1370

merged 1 commit into from
Aug 22, 2018

Conversation

ComiR
Copy link
Contributor

@ComiR ComiR commented Aug 21, 2018

The code migration has to respect type hints already present. Otherwise there would be a illegal duplicate type hint.

albe
albe approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading

kitsunet
kitsunet approved these changes Aug 22, 2018
View reviewed changes
Copy link
Member

@kitsunet kitsunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked the regex and that seems all well to me.

@kitsunet kitsunet merged commit 9659930 into neos:5.0 Aug 22, 2018
@albe albe deleted the patch-5 branch August 22, 2018 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsunet kitsunet kitsunet approved these changes

@albe albe albe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ComiR @kitsunet @albe