-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Translator uses locale chain #1451
Conversation
9a4ef2c
to
10e542c
Compare
Excuse my use of the force (especially because it gets documented now in the PR 👍), but I had to fix the tests with the help of Travis ;) |
Huh, I created a different solution "by accident", see #1555 |
Well, not quite. In the case of the XLIFF source language being the same as the fallback language in the locale chain: yes. But for all other cases: no. |
Hi, Thanks, |
Thanks @DavidSporer for the verification and thanks @ComiR for the long lasting effort! I do think this is good to go when the originalLabel interpolation is in place again (which I'll add just now). But technically it's a new feature (changes behaviour) as is, so it should probably be retargeted to master. I'd love to have this in lower versions too, it just makes so much sense after all, but can't play with semver just for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good…
This change makes getTranslationById and getTranslationByOriginalLabel use the configured
locale chain.
This is an updated version of #327 and #328. Please see the discussions there. May be retargeted on master.