BUGFIX: Omit sessionless tokens from session #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this fix, all security tokens – including those which are implementations of SessionlessTokenInterface – are serialized and added to the current session. This is a problem for sessionless tokens, which need to be updated on every request on not just once per session. Backport of #1662
|
Note: this needs careful upmerging from 5.1 -> 5.2 |
bwaidelich
reviewed
Jul 9, 2019
There was a problem hiding this comment.
Thanks for taking care of backporting this!
Makes sense, I'll just go ahead and add some tests like done for #1662
bwaidelich
approved these changes
Jul 9, 2019
|
Forgot to merge this first before doing upmerges, d'oh |
kdambekalns
added a commit
to flownative/flow-openidconnect-client
that referenced
this pull request
Oct 24, 2019
This removes the SessionlessTokenBugfixAspect from the codebase, as the underlying problem is fixed in Flow 4.3 and up with these PRs: - neos/flow-development-collection#1662 - neos/flow-development-collection#1663 As such, minimum Flow versions are raised to the following: - 4.3.18 - 5.0.17 - 5.1.11 - 5.2.7 - 5.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, all security tokens – including those which are
implementations of SessionlessTokenInterface – are serialized and
added to the current session. This is a problem for sessionless
tokens, which need to be updated on every request on not just once
per session.
Backport of #1662
Fixes: #1666