TASK: Use yield instead of AppendIterator in getObjects #1842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not 100% sure about that removed |
kitsunet
approved these changes
Nov 6, 2019
|
Not good really, because |
But we could just do that? Like iterate the inner generators? Seems fine to me |
|
Good now, but probably needs retargeting to 4.3, or at least 6.0? |
|
6.0 according to Travis… |
|
I'll move that to 6.0 |
kdambekalns
force-pushed
the
albe-collection-generator
branch
from
fbf0228
to
1456d65
Compare
skurfuerst
added a commit
that referenced
this pull request
Nov 8, 2019
This fixes a regression introduced in #1842: In this change, a "yield" and a "return" call were introduced in the same method; so that the early return was not properly executed because PHP somehow thought this is a fully-suspendable function, although only one part of the "if"-statement was suspendable. Related: #1842
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method docblock stated that it returns a
Generator, while in reality for aPackageStoragewith patterns, it would fall back to anAppendIterator.This change instead makes use of
yieldto return theStorageObjectsin a memory-efficient manner.