Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Uploaded file upcasting with multiple files #1862

Merged
merged 1 commit into from Mar 3, 2020
Merged

Conversation

ComiR
Copy link
Contributor

@ComiR ComiR commented Nov 29, 2019

When uploading multiple files (i.e. in an array), the existing files (persisted resource) would be dropped.

By modifying the $currentPath value, Flow built a wrong path:
The first file would be fine - f.e. path "files.0", but the second one will fail due to the path being "files.0.1" instead of "files.1".

fixes #1857

Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Thanks for finding and fixing. Having that covered with a test would be awesome though...

@albe albe requested a review from kitsunet December 19, 2019 09:34
@albe albe merged commit d1ae04e into neos:6.0 Mar 3, 2020
@albe albe deleted the patch-9 branch March 3, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants