Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Fix validation warnings/errors on .travis.yml #1908

Merged
merged 1 commit into from
Feb 16, 2020

Conversation

kdambekalns
Copy link
Member

Fixes build config validation complaints:

  • W notifications.slack: unknown key on_start (never)
  • I root: missing os, using the default linux
  • I root: key matrix is an alias for jobs, using jobs

@kdambekalns
Copy link
Member Author

Still a draft, because it already includes the upmerges I intend to push independently as soon as their tests pass…

Fixes build config validation complaints:

- W notifications.slack: unknown key on_start (never)
- I root: missing os, using the default linux
- I root: key matrix is an alias for jobs, using jobs
@kdambekalns kdambekalns marked this pull request as ready for review February 14, 2020 10:32
@gerhard-boden
Copy link
Contributor

just restarted tests, travis has tripped

@gerhard-boden
Copy link
Contributor

Where do you take care of W notifications.slack: unknown key on_start (never)?

@kdambekalns
Copy link
Member Author

@gerhard-boden Removal of line 100

@gerhard-boden
Copy link
Contributor

whoops sorry, i misread the diff (looked like it belonged to jobs key because of truncation)

Copy link
Contributor

@gerhard-boden gerhard-boden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are also green now!

@gerhard-boden
Copy link
Contributor

gerhard-boden commented Feb 16, 2020

since neos/neos-development-collection#2901 has already been merged and the suggested adjustments are also included there, I'll go ahead and merge this as well

@gerhard-boden gerhard-boden merged commit b78e599 into neos:5.3 Feb 16, 2020
@kdambekalns kdambekalns deleted the task/fix-travis-config branch February 17, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants