Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! BUGFIX: Adjust to TYPO3Fluid 2.5.11 and 2.6.10 signature changes #2257

Merged
merged 6 commits into from Nov 17, 2020

Conversation

albe
Copy link
Member

@albe albe commented Nov 16, 2020

With this you need to update to TYPO3 Fluid 2.5.11+ or 2.6.10+

See TYPO3/Fluid@f20db4e#r44244534

@albe
Copy link
Member Author

albe commented Nov 16, 2020

ERROR: UndefinedMethod - Packages/Framework/Neos.FluidAdaptor/Classes/Core/Parser/SyntaxTree/ResourceUriNode.php:52:16 - Method Neos\FluidAdaptor\Core\Parser\SyntaxTree\ResourceUriNode::rewriteBooleanNodesInArgumentsObjectTree does not exist (see https://psalm.dev/022)
$this->rewriteBooleanNodesInArgumentsObjectTree($this->argumentDefinitions, $this->arguments);
ERROR: UndefinedMethod - Packages/Framework/Neos.FluidAdaptor/Classes/Core/Parser/SyntaxTree/ResourceUriNode.php:53:16 - Method Neos\FluidAdaptor\Core\Parser\SyntaxTree\ResourceUriNode::validateArguments does not exist (see https://psalm.dev/022)
$this->validateArguments($this->argumentDefinitions, $this->arguments);

Still something to do...

Edit: See TYPO3/Fluid@022c306 - this logic was moved apparently

@bwaidelich
Copy link
Member

Should be marked breaking since the two @api methods AbstractViewHelper::registerArgument() & AbstractViewHelper::overrideArgument() changed

Copy link
Member

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

Co-authored-by: Bastian Waidelich <b.waidelich@wwwision.de>
composer.json Outdated Show resolved Hide resolved
@albe albe changed the title BUGFIX: Adjust to TYPO3Fluid 2.6.10 signature changes !!! BUGFIX: Adjust to TYPO3Fluid 2.5.11 and 2.6.10 signature changes Nov 17, 2020
@albe albe merged commit 360c6d7 into master Nov 17, 2020
@albe albe deleted the albe-fluid-26-10 branch November 17, 2020 09:51
@albe
Copy link
Member Author

albe commented Nov 17, 2020

Post-merge addendum: Claus had a good observation on our implementation: TYPO3/Fluid#529 (comment)

Maybe that's the more sane way to go for 7.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants