Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! BUGFIX: Adjust to TYPO3Fluid 2.5.11 and 2.6.10 signature changes #2257

Merged
merged 6 commits into from Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -49,8 +49,6 @@ public function injectViewHelperResolver(ViewHelperResolver $viewHelperResolver)
$this->uninitializedViewHelper = $this->viewHelperResolver->createViewHelperInstanceFromClassName($this->viewHelperClassName);
$this->uninitializedViewHelper->setViewHelperNode($this);
$this->argumentDefinitions = $this->viewHelperResolver->getArgumentDefinitionsForViewHelper($this->uninitializedViewHelper);
$this->rewriteBooleanNodesInArgumentsObjectTree($this->argumentDefinitions, $this->arguments);
$this->validateArguments($this->argumentDefinitions, $this->arguments);
}

/**
Expand Down
10 changes: 6 additions & 4 deletions Neos.FluidAdaptor/Classes/Core/ViewHelper/AbstractViewHelper.php
Expand Up @@ -89,16 +89,17 @@ public function injectLogger(LoggerInterface $logger): void
* @param string $description Description of the argument
* @param boolean $required If true, argument is required. Defaults to false.
* @param mixed $defaultValue Default value of argument
* @param boolean|null $escape Can be toggled to TRUE to force escaping of variables and inline syntax passed as argument value.
* @return FluidAbstractViewHelper $this, to allow chaining.
* @throws Exception
* @api
*/
protected function registerArgument($name, $type, $description, $required = false, $defaultValue = null)
protected function registerArgument($name, $type, $description, $required = false, $defaultValue = null, $escape = null)
{
if (array_key_exists($name, $this->argumentDefinitions)) {
throw new Exception('Argument "' . $name . '" has already been defined, thus it should not be defined again.', 1253036401);
}
return parent::registerArgument($name, $type, $description, $required, $defaultValue);
return parent::registerArgument($name, $type, $description, $required, $defaultValue, $escape);
}

/**
Expand All @@ -114,16 +115,17 @@ protected function registerArgument($name, $type, $description, $required = fals
* @param string $description Description of the argument
* @param boolean $required If true, argument is required. Defaults to false.
* @param mixed $defaultValue Default value of argument
* @param boolean|null $escape Can be toggled to TRUE to force escaping of variables and inline syntax passed as argument value.
* @return FluidAbstractViewHelper $this, to allow chaining.
* @throws Exception
* @api
*/
protected function overrideArgument($name, $type, $description, $required = false, $defaultValue = null)
protected function overrideArgument($name, $type, $description, $required = false, $defaultValue = null, $escape = null)
{
if (!array_key_exists($name, $this->argumentDefinitions)) {
throw new Exception('Argument "' . $name . '" has not been defined, thus it can\'t be overridden.', 1279212461);
}
return parent::overrideArgument($name, $type, $description, $required, $defaultValue);
return parent::overrideArgument($name, $type, $description, $required, $defaultValue, $escape);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion Neos.FluidAdaptor/composer.json
Expand Up @@ -11,7 +11,7 @@
"neos/cache": "*",
"neos/utility-files": "*",
"neos/utility-objecthandling": "*",
"typo3fluid/fluid": "^2.5",
"typo3fluid/fluid": "~2.5.11 || ^2.6.10",
"psr/log": "^1.0"
},
"autoload": {
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Expand Up @@ -31,7 +31,7 @@
"neos/composer-plugin": "^2.0",
"composer/composer": "^1.9",
"egulias/email-validator": "^2.1",
"typo3fluid/fluid": "^2.5",
"typo3fluid/fluid": "~2.6.10",
albe marked this conversation as resolved.
Show resolved Hide resolved
"guzzlehttp/psr7": "^1.4 || ~2.0",
"ext-mbstring": "*"
},
Expand Down