Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use GH actions for builds #2273

Merged
merged 59 commits into from
Feb 22, 2021
Merged

TASK: Use GH actions for builds #2273

merged 59 commits into from
Feb 22, 2021

Conversation

albe
Copy link
Member

@albe albe commented Nov 21, 2020

Still WIP, needs to be backported to lowest maintained branch once finished, but I want to get psalm running too and that's not in <6.0

@albe
Copy link
Member Author

albe commented Nov 21, 2020

Regarding testing against PHP 8 (or any other "allow-failure" dependency) - see actions/runner#2347

@albe
Copy link
Member Author

albe commented Dec 2, 2020

PHP Warning: require(/home/runner/work/flow-development-collection/flow-development-collection/flow-development-collection/Neos.Flow/Classes/Core/../../../../Libraries/autoload.php): failed to open stream: No such file or directory in /home/runner/work/flow-development-collection/flow-development-collection/flow-development-collection/Neos.Flow/Classes/Core/Bootstrap.php on line 88

Guess that's because there's a discrepancy in the relative placement of the distribution and collection in travis vs this? Or is it because of (not) symlinking the collection and paths being resolved differently?

@albe
Copy link
Member Author

albe commented Dec 26, 2020

Solved by using non-symlinking path repo in the composer config, like in #2287

Now two console output tests fail oddly:

1) Neos\Flow\Tests\Unit\Cli\ConsoleOutputTest::selectWithStringTypeChoiceKeys
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 'Is this a good test?\n
   [n] No\n
   [y] Yes\n
- > y'
+ > '

/home/runner/work/flow-development-collection/flow-development-collection/flow-development-distribution/Packages/Framework/Neos.Flow/Tests/Unit/Cli/ConsoleOutputTest.php:240

I have seen this failure on my windows runs, but always assumed that was due to how windows PHP handled console output. So I'm unsure what the cause is in this case, as the build is running on ubuntu

@albe
Copy link
Member Author

albe commented Feb 15, 2021

TODO: Get remaining skipped tests running (I guess those are primarily the cache tests for specific backends)

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@albe
Copy link
Member Author

albe commented Feb 15, 2021

Possible alternative for setting up the database service so it is configurable per run (e.g. could be skipped for static analysis run): https://github.com/cakephp/cakephp/blob/master/.github/workflows/ci.yml#L41-L55

@albe
Copy link
Member Author

albe commented Feb 15, 2021

Still 38 skipped Unit tests and 30 skipped Functional tests... 🤔 anyone has an idea? @kdambekalns ?

@albe
Copy link
Member Author

albe commented Feb 19, 2021

Only a few skipped tests remaining now, which are semi-concious choices and not dependent on the setup. We need to revisit those at some point. LGTM, but I will create another PR for 5.3 so we have builds across all branches after an upmerge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants