BUGFIX: Avoid race condition on symlink publishing #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the symlink could not be created but exists, check if it points to the expected target and ignore the error in that case. Fixes #2667
kdambekalns
requested review from
robertlemke,
kitsunet,
markusguenther and
albe
|
ping… |
|
ping … |
1 similar comment
|
ping … |
mhsdesign
reviewed
Mar 22, 2022
| $result = false; | ||
| } | ||
|
|
||
| if (Files::is_link($targetPathAndFilename) && realpath($targetPathAndFilename) === realpath($sourcePathAndFilename)) { |
There was a problem hiding this comment.
can there be a situation where both realpath return false? (since false === false)
i only know that realpath doesnt like stream wrapper and returns false then ...
There was a problem hiding this comment.
Oh, well. Technically, yes, that could happen. But I think we can ignore that here.
mhsdesign
approved these changes
Mar 23, 2022
|
btw i do noticed the odd exception handling and returning arrays and stuff, but fixing this is not a bugfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the symlink could not be created but exists, check if it points to
the expected target and ignore the error in that case.
Fixes #2667