New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Avoid race condition on symlink publishing #2669
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
bb7279d
TASK: Extract duplicate publish code into method
kdambekalns 69ed476
BUGFIX: Check for correct symlink after error
kdambekalns 404dc0e
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
kdambekalns eb2f8b2
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
kdambekalns 1004aa1
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
kdambekalns 6e464c2
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
kdambekalns f824cab
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
kdambekalns bbf39f2
Merge branch '6.3' into bugfix/2667-publish-symlink-race-condition
jonnitto File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can there be a situation where both
realpath
returnfalse
? (sincefalse === false
)i only know that
realpath
doesnt like stream wrapper and returns false then ...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, well. Technically, yes, that could happen. But I think we can ignore that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍