TASK: Refactor absolute namespaces in Flow / Command classes #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniellienert, thanks for your PR! By analyzing the annotation information on this pull request, we identified @kdambekalns, @ComiR and @robertlemke to be potential reviewers |
Additionally refactor legacy array syntax.
daniellienert
force-pushed
the
task/refactor-namespaces-in-command-classes
branch
from
dfaab03
to
3b0d188
Compare
|
The one |
| @@ -189,7 +191,7 @@ public function cleanCommand() | |||
| } | |||
| } | |||
| } | |||
| $this->outputLine('Removed %s resource object(s) from the database.', array(count($brokenResources))); | |||
| $this->outputLine('Removed %s resource object(s) from the database.', [count($brokenResources)]); | |||
| break; | |||
There was a problem hiding this comment.
Sorry Christian - what do you mean?
There was a problem hiding this comment.
Uhm, I think it was a display error in the diff view, now iwth the comments it looks normal so nevermind. It looked like the rest of the cases was deleted as well....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally refactor legacy array syntax.