BUGFIX: Consider accounts with expirationDate in the future as active
#875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maltemuth, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kdambekalns, @daniellienert and @robertlemke to be potential reviewers. |
aertmann
changed the title
expirationDate in the future as active
|
tests don't pass |
aertmann
approved these changes
Feb 23, 2017
|
@aertmann it does; Now is the timestamp of object instantiation and not equal to \DateTime("now") - this is why tests failed if the suite takes longer than one minute to run. However, lazy-loading had the side effect of breakage. |
kdambekalns
approved these changes
Feb 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I fixed
Account::isActive()behavior when an expirationDate is set.How I did it
The "Now" injection is now non-lazy, thus the comparison of DateTime objects works.
How to verify it
Run the new functional test
TYPO3.Flow/Tests/Functional/Security/AccountTest.phpChecklist
Fixes #873