FEATURE: Show all form fields in Placeholder-Insert #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crydotsnake
requested changes
Nov 12, 2023
erkenes
force-pushed
the
feature/ee-issue-99_2
branch
from
16d917d
to
1336c11
Compare
crydotsnake
approved these changes
Mar 4, 2024
mhsdesign
reviewed
Mar 4, 2024
| const node = this.props.nodesByContextPath[element.contextPath]; | ||
| const childNodes = this.props.nodesByContextPath[element.contextPath].children; | ||
|
|
||
| if (nodeTypeRegistry.isOfType(node.nodeType, 'Neos.Form.Builder:Mixin.PlaceholderInsert')) { |
There was a problem hiding this comment.
this wont work right away, due to the optimisations to the schema: neos/neos-ui#3677
There was a problem hiding this comment.
I fixed this. It is required to add the nodetypes to the frontend configuration and it is possible to exclude all child nodes of a specific node type (which is useful for the options and validator collection because it is not required to list them all)
erkenes
force-pushed
the
feature/ee-issue-99_2
branch
from
1336c11
to
9603b8e
Compare
erkenes
changed the title
- Create a frontend settings by which Form-Elements
are shown in the placeholder insert
- Load all form-elements recursively
- Check if the elements are allowed to shown in the
Placeholder-Insert-Dropdown by checking if they
are not in the setting
Resolves: neos#99
fields of further pages were not available in the placeholder-insert Related to: neos#99
erkenes
force-pushed
the
feature/ee-issue-99_2
branch
from
9603b8e
to
d7a67b4
Compare
|
It is now also possible to list the fields of the further pages in the Placeholder-Insert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #99