Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Include Allow third-party fusion code for fusion forms #21

Merged

Conversation

@daniellienert
Copy link
Member

daniellienert commented Feb 7, 2020

Fusion code from additional packages can be loaded
using a similar configuration to Neos.Neos.fusion.autoInclude

Fixes: #9

Fusion code from additional packages can be loaded
using a similar configuration to `Neos.Neos.fusion.autoInclude`
@daniellienert daniellienert requested a review from bwaidelich Feb 7, 2020
daniellienert added a commit to daniellienert/honeypotformfield that referenced this pull request Feb 7, 2020
@daniellienert

This comment has been minimized.

Copy link
Member Author

daniellienert commented Feb 7, 2020

Includes #20

@bwaidelich

This comment has been minimized.

Copy link
Member

bwaidelich commented Feb 7, 2020

Great, thanks for this. Looks great by reading but it would be nice if we could add a short example to the README, don't you think?

@daniellienert

This comment has been minimized.

Copy link
Member Author

daniellienert commented Feb 7, 2020

Sure, if we'll do it this way, I add some documentation

@bwaidelich

This comment has been minimized.

Copy link
Member

bwaidelich commented Feb 7, 2020

Sure, if we'll do it this way, I add some documentation

I think, it makes a lot of sense and is not breaking!

Copy link
Member

bwaidelich left a comment

Looks good, by reading. Thanks!

@daniellienert daniellienert merged commit bb365a6 into neos:master Feb 7, 2020
@daniellienert daniellienert deleted the daniellienert:feature/include-3rd-party-fusion branch Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.