Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! FEATURE: Add getProperty to FormElement & add getRenderingOption to AbstractRenderable #159

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

erkenes
Copy link
Contributor

@erkenes erkenes commented Sep 12, 2022

  • Add getRenderingOption-Function to the AbstractRenderable-Model
  • Add getProperty-Function to FormElement

Those functions are helpful for Custom Form Elements to get simpler access to a property or rendering option.

Add getProperty-Function to FormElement
Add getRenderingOption-Function to the
AbstractRenderable-Model
@bwaidelich
Copy link
Member

Thanks for your contribution.
I think this change makes sense, but we must consider it a breaking change (requiring a new major version release) because it changes interfaces

@erkenes
Copy link
Contributor Author

erkenes commented Sep 13, 2022

Thanks for your contribution. I think this change makes sense, but we must consider it a breaking change (requiring a new major version release) because it changes interfaces

You're right but I think this change is a good improvement because we dont have to call getProperties() anymore and have to check first if the required key exists to use the value then

@bwaidelich bwaidelich changed the title feat: Add getProperty to FormElement & add getRenderingOption to AbstractRenderable FEATURE: Add getProperty to FormElement & add getRenderingOption to AbstractRenderable Sep 13, 2022
@bwaidelich bwaidelich added enhancement breaking change A change that requires a new major release labels Sep 13, 2022
Adds the function `getProperty` to the Section
due to changes on the interface
@bwaidelich bwaidelich changed the title FEATURE: Add getProperty to FormElement & add getRenderingOption to AbstractRenderable !!! FEATURE: Add getProperty to FormElement & add getRenderingOption to AbstractRenderable Sep 13, 2022
@bwaidelich bwaidelich merged commit 6bec0fa into neos:master Sep 13, 2022
@dlubitz
Copy link
Contributor

dlubitz commented Apr 18, 2023

Unfortunately it ended up in a minor release (5.4)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A change that requires a new major release enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants