[BUGFIX] Use correct node for content collection metadata #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content collection handles are not shown since the meta data added is using the document node instead of the actual node. Regression introduced with ``4672697b9477ceca53ee7b4e47c4def002e50e32`` causing the node not to be set correctly for the ``contentElementWrapping`` processor. Related: NEOS-1326
|
👍 surprised nobody has found this before (broken since 1.2.10) Not a problem in Verify by selecting a content collection in the structure tree and notice the lack of the handles. Broken: Fixed: |
|
Looks good 👍 |
|
👍 by reading |
|
👍 by reading. |
|
👍 |
|
thanks for the reviews :) |
aertmann
added a commit
that referenced
this pull request
Nov 18, 2015
[BUGFIX] Use correct node for content collection metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content collection handles are not shown since the meta data
added is using the document node instead of the actual node.
Regression introduced with 4672697
causing the node not to be set correctly for the
contentElementWrappingprocessor.Related: NEOS-1326