TASK: Cleanup of internal VIE usage in JS backend #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Aske, I just read over the change, and I really like what I have seen. So from my side, this is a 👍 by reading, although I think this change needs some more intense testing. All the best, |
|
@kdambekalns it's not important for the release, so will probably rebase after feature freeze |
|
and it's basically just stuff I found while fixing #186 |
|
👍 |
|
Looks good and seems to work fine. Just played with it a bit. 👍 but conflicts need to be solved before merging. |
|
rebased |
|
👍 fixed StyleCI issue (unrelated to change) |
aertmann
changed the title
|
👍 rebased |
When a new page is loaded the node type and node type label wasn't updated for the page root node in the context structure tree.
Adds a getter method for retrieving a previous attribute from the VIE entity instead of accessing VIE directly or getting all attributes just to get one.
Removes usage of the VIE entity in the trees used by the listernes, instead the node entity is used.
Adds a getter method for checking if a attribute exists in the VIE entity instead of accessing VIE directly or getting all attributes to check.
|
included all of the changes in #416 instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes a lot of the direct interaction with VIE and replaces it with the node model.
Additionally the VIE namespace is no longer used outside VIE so the configuration is removed.