BUGFIX: Avoid getPath() on null in LinkingService #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the context of the "resolved" node does not have a "current" site in `LinkingService.createNodeUri()` a fatal error was triggered. This adds a check and handles the case like a site node path mismatch.
kdambekalns
requested review from
robertlemke,
bwaidelich,
kitsunet and
aertmann
kitsunet
approved these changes
Apr 3, 2018
|
I'm not into the |
|
Can happen if said node instance has a CR Context and not a Neos Context. IMHO the whole concept of currentSiteNode() needs to be gone from the Context. The fallback is more or less what should happen all the time, as any given node knows best what site it belongs to. |
aertmann
approved these changes
Apr 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the context of the "resolved" node does not have a "current" site
in
LinkingService.createNodeUri()a fatal error was triggered. Thisadds a check and handles the case like a site node path mismatch.