[BUGFIX] Broken workspace managment backend module #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a couple of issues with the new workspace management features and improves the user interface in the workspace review screen. Editing the owner of a workspace resulted in a fatal error due to a wrong method signature. Ownership can now be transferred as intended. The rebase and redirect action (which can convenientely be triggered through an edit button in the review screen) complained about a wrong "$this" in a fatal error. Removed $this and now that works. At the bottom of the review workspace changes screen a small help message explained what would happen when a user presses one of the buttons. Removed that fineprint and now let the buttons speak for themselves.
| @@ -65,15 +66,18 @@ privilegeTargets: | |||
| matcher: 'method(TYPO3\Neos\Controller\Module\Management\WorkspacesController->(index|show|publishNode|discardNode|publishOrDiscardNodes|publishWorkspace|discardWorkspace|rebaseAndRedirect)Action()) || method(TYPO3\Neos\Service\Controller\AbstractServiceController->(error)Action())' | |||
|
|
|||
| 'TYPO3.Neos:Backend.Module.Management.Workspaces.ManageOwnWorkspaces': | |||
| matcher: 'method(TYPO3\Neos\Controller\Module\Management\WorkspacesController->(publishWorkspace|discardWorkspace|edit|update|delete)Action(workspace.owner == current.userInformation.backendUser))' | |||
| matcher: 'method(TYPO3\Neos\Controller\Module\Management\WorkspacesController->(publishWorkspace|discardWorkspace|edit|update|delete)Action())' | |||
There was a problem hiding this comment.
If this is not needed, rather leave it as it was…
There was a problem hiding this comment.
To me without that change everything works fine, so that can be undone.
This reverses a change in the policy that is not needed and was added as the result of trial and error.
|
👍 from me |
|
👎 still discovered a bug, will provide a fix as soon as possible.
|
When editing a workspace in the workspace management module and selecting "no owner", the updateAction failed while trying to set owner to an empty string.
|
👍 manually tested all actions in the workspace management, looks good to me now |
|
👍 |
|
👍 looks good now! |
robertlemke
added a commit
that referenced
this pull request
Nov 26, 2015
[BUGFIX] Broken workspace management backend module This fixes a couple of issues with the new workspace management features and improves the user interface in the workspace review screen. Editing the owner of a workspace resulted in a fatal error due to a wrong method signature. Ownership can now be transferred as intended. The rebase and redirect action (which can conveniently be triggered through an edit button in the review screen) complained about a wrong "$this" in a fatal error. Removed $this and now that works. At the bottom of the review workspace changes screen a small help message explained what would happen when a user presses one of the buttons. Removed that fine print and now let the buttons speak for themselves.
|
Merged this, since it's a hot fix to solve a regression in our shippable master. |
skurfuerst
added a commit
that referenced
this pull request
May 3, 2022
FEATURE: neos/redirecthandler adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple of issues with the new workspace management features
and improves the user interface in the workspace review screen.
Editing the owner of a workspace resulted in a fatal error due to
a wrong method signature. Ownership can now be transferred as intended.
The rebase and redirect action (which can conveniently be triggered
through an edit button in the review screen) complained about a wrong
"$this" in a fatal error. Removed $this and now that works.
At the bottom of the review workspace changes screen a small help
message explained what would happen when a user presses one of the
buttons. Removed that fine print and now let the buttons speak for
themselves.