Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP FEATURE: Reduced stylesheet for backend modules #2874

Draft
wants to merge 1 commit into
base: master
from

Conversation

@Sebobo
Copy link
Member

Sebobo commented Jan 22, 2020

The old stylesheets from pre-react times override a lot of basic styles for backend modules.
This makes it hard to implement custom styles there or use our react ui components.

The idea would be to provide an alternative stylesheet that only brings what is needed for the backend "frame" and doesn't reset tag styles with the .neos prefix.

The idea is based on a discussion between @skurfuerst and me on 21.01.2020

@Sebobo Sebobo requested a review from skurfuerst Jan 22, 2020
@Sebobo

This comment has been minimized.

Copy link
Member Author

Sebobo commented Jan 22, 2020

@skurfuerst this worked easier than expected as @markusguenther already did some work for Neos 5.1.
With the styles in the NeosLite.scss the backend modules looked fine so far. I haven't check everything in detail. But I'm also sure that more things can be removed or be moved outside the .neos prefix.

@Sebobo Sebobo requested a review from markusguenther Jan 22, 2020
@Sebobo Sebobo force-pushed the Sebobo:feature/reduced-stylesheet branch from ee44f95 to bca9351 Jan 22, 2020
@skurfuerst

This comment has been minimized.

Copy link
Member

skurfuerst commented Jan 23, 2020

That looks awesome <3 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.