Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Add types to workspace model #2921

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

daniellienert
Copy link
Member

No description provided.

Co-Authored-By: Karsten Dambekalns <karsten@dambekalns.de>
@Sebobo
Copy link
Member

Sebobo commented Jul 1, 2020

Is this change safe for 5.3 or meant for 6.0?

@daniellienert
Copy link
Member Author

@kdambekalns, @albe thanks for the reviews. Would you have another look?

@daniellienert
Copy link
Member Author

@Sebobo they should be pretty safe for 5.3

Copy link
Member

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading

@daniellienert daniellienert merged commit bc712c4 into neos:master Aug 11, 2020
@daniellienert daniellienert deleted the task/cleanup-workspace-model branch August 11, 2020 15:39
markusguenther pushed a commit to markusguenther/neos-development-collection that referenced this pull request Mar 25, 2021
…e-model

TASK: Add types to workspace model
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants