-
-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Add types to workspace model #2921
Merged
daniellienert
merged 3 commits into
neos:master
from
daniellienert:task/cleanup-workspace-model
Aug 11, 2020
Merged
TASK: Add types to workspace model #2921
daniellienert
merged 3 commits into
neos:master
from
daniellienert:task/cleanup-workspace-model
Aug 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellienert
force-pushed
the
task/cleanup-workspace-model
branch
from
February 26, 2020 16:46
31c6fea
to
a95c193
Compare
kdambekalns
reviewed
Feb 28, 2020
Co-Authored-By: Karsten Dambekalns <karsten@dambekalns.de>
albe
reviewed
Mar 31, 2020
Is this change safe for 5.3 or meant for 6.0? |
kdambekalns
requested changes
Jul 1, 2020
@kdambekalns, @albe thanks for the reviews. Would you have another look? |
@Sebobo they should be pretty safe for 5.3 |
albe
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good by reading
Sebobo
approved these changes
Aug 11, 2020
kdambekalns
approved these changes
Aug 11, 2020
markusguenther
pushed a commit
to markusguenther/neos-development-collection
that referenced
this pull request
Mar 25, 2021
…e-model TASK: Add types to workspace model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.