BUGFIX: Use "stable" identifier when auto-creating child nodes #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ``node:repair`` uses the ``buildAutoCreatedChildNodeIdentifier``, it would best to ensure the ``identifier`` is already correct when auto-creating child nodes. Otherwise the identifier will be changed to a so called "stable" identifier during a ``node:repair`` run which can lead to unwanted behaviour in certain applications.
|
@albe this one should be merged before we say goodbye to 4.3 ... |
bwaidelich
reviewed
Apr 26, 2021
| $childNodeType, | ||
| Utility::buildAutoCreatedChildNodeIdentifier( | ||
| $childNodeName, | ||
| $node->getNodeAggregateIdentifier() |
There was a problem hiding this comment.
Is getNodeAggregateIdentifier() available in 4.3?
bwaidelich
approved these changes
Apr 26, 2021
|
thanks for the reviews! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
node:repairuses thebuildAutoCreatedChildNodeIdentifier, it wouldbest to ensure the
identifieris already correct when auto-creating child nodes.Otherwise the identifier will be changed to a so called "stable"
identifier during a
node:repairrun which can lead to unwantedbehaviour in certain applications.