BUGFIX: Allow non-entity asset variants #4198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhsdesign
reviewed
Feb 5, 2024
Allow implementations of the `AssetVariantInterface` to not be doctrine entities.
Without this fix, all `AssetRepository::find*()` calls lead to an exception when a class implements the interface
but is not an entity (for example because it is just used to generate dummy images for Monocle).
1. Implement the interface with a new custom class like
```php
final class DummyImageVariant implements AssetVariantInterface {
// ...
}
```
2. Trigger `AssetRepository::find*()` method, eg. by invoking `./ flow media:removeunused`
No error, the custom implementation should be ignored
Exception:
```
Failure while fetching class schema class "Some\Package\DummyImageVariant": No class schema found for "Some\Package\DummyImageVariant".
Type: Doctrine\ORM\Mapping\MappingException
Code: 1542792708
File: Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Flow_Persist
ence_Doctrine_Mapping_Driver_FlowAnnotationDriver.php
Line: 187
```
mhsdesign
force-pushed
the
bugfix/allow-non-entity-asset-variants
branch
from
530695d
to
e17fdca
Compare
mhsdesign
approved these changes
Feb 8, 2024
|
fixed again :) |
The fix no longer worked with 8.3 due to some other changes, so it was adjusted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow implementations of the
AssetVariantInterfaceto not be doctrine entities.Without this fix, all
AssetRepository::find*()calls lead to an exception when a class implements the interface but is not an entity (for example because it is just used to generate dummy images for Monocle).Steps to reproduce
AssetRepository::find*()method, eg. by invoking./ flow media:removeunusedExpected result
No error, the custom implementation should be ignored
Actual result
Exception: