Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUGFIX: Allow non-entity asset variants #4198

Merged
merged 2 commits into from
Feb 22, 2024
Merged

BUGFIX: Allow non-entity asset variants #4198

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17fdca
BUGFIX: Allow non-entity asset variants
bwaidelich Apr 17, 2023
8e2e1b9
Update AssetRepository.php
bwaidelich Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions Neos.Media/Classes/Domain/Repository/AssetRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,10 @@ protected function addAssetVariantToQueryConstraints(QueryInterface $query): voi
$variantsConstraints = [];
$variantClassNames = $this->reflectionService->getAllImplementationClassNamesForInterface(AssetVariantInterface::class);
foreach ($variantClassNames as $variantClassName) {
if (!in_array(AssetInterface::class, class_implements($variantClassName), true)) {
// ignore non-entity classes to prevent "class schema found" error
continue;
}
$variantsConstraints[] = 'e NOT INSTANCE OF ' . $variantClassName;
}

Expand Down