BUGFIX: props will be unset after an exception

[mhsdesign]

Resolves: #4525

The rendering in a Neos.Fusion Component had a bug where the props might be undefined if an exception happened earlier in an eel expression.

This was caused by not correctly poping the runtimes context and thus causing a unexpected shift in the context stack.

Upgrade instructions

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[bwaidelich]

I would love to see some more explanation or even a test that fails without the fix, but it seems like a sensible change!

[Benjamin-K]

I know, this is already merged. But shouldn't the context be popped again in any case?

try {
    // New implementation, return will immediatly stop
    // return $this->runtime->render($this->path . '/renderer');
    // Should be this IMO
    $result = $this->runtime->render($this->path . '/renderer');
} finally {
    // This will never be triggered if return is used above
    $this->runtime->popContext();
}
// Return should be used after popContext()
return $result;

[mhsdesign]

hi :D no thats fine because finally is really cool. Its the same. finally ALWAYS happens even if there is a return. Super cool right :D