BUGFIX: Private props obscure error

[mhsdesign]

…uated

instead of the original error that something went wrong

Circular reference detected while evaluating prop: "private.thepath"

is shown.

That happens because the locking didnt anticipate this case.

Upgrade instructions

Review instructions

this code reproduces the problem ... yes i know :D

prototype(YourVendor:FusionPrototype) < prototype(Neos.Fusion:Component) {
  @private {
    lol = ${true}
    throwingPath = ${private.lol && NonExistingFunctionError()}
  }

  renderer = YourVendor:FusionPrototypeWithPrivate {
    content = ${private.throwingPath}
  }
}

prototype(YourVendor:FusionPrototypeWithPrivate) < prototype(Neos.Fusion:Component) {
  renderer = ${props.content}
}

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kitsunet]

All I see is a function called deref burning my eyes 😂

[kitsunet]

big 👀 to deref but the fix seems good.

[mhsdesign]

Found a way to reproduce it ^^ and its somehow related to #4526 but probably only by its weirdness.

[Sebobo]

LGTM