Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Behat-based Fusion tests (v1) #4641

Merged
merged 10 commits into from Oct 30, 2023
Merged

TASK: Behat-based Fusion tests (v1) #4641

merged 10 commits into from Oct 30, 2023

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Oct 23, 2023 •
edited

Related: #3594

@github-actions github-actions bot added the 8.3 label Oct 23, 2023
@mhsdesign mhsdesign changed the title initial version 3594-behat-based-fusion-tests Oct 23, 2023
@bwaidelich bwaidelich changed the title 3594-behat-based-fusion-tests TASK: Behat-based Fusion tests Oct 27, 2023
@github-actions github-actions bot added the Task label Oct 27, 2023
@bwaidelich bwaidelich changed the title TASK: Behat-based Fusion tests TASK: Behat-based Fusion tests (v1) Oct 29, 2023
@bwaidelich bwaidelich mentioned this pull request Oct 29, 2023
Merged
@bwaidelich bwaidelich marked this pull request as ready for review October 30, 2023 08:33
@bwaidelich bwaidelich mentioned this pull request Oct 30, 2023
Closed
mficzel
mficzel approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mficzel mficzel left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by 👀 ... what an epic. Thanks for fighting this

mhsdesign
mhsdesign approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mhsdesign mhsdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care. I didnt had a look exactly about all the test cases, but i like the new FusionTrait and how you use it.

@mhsdesign mhsdesign merged commit 9ab98a4 into 8.3 Oct 30, 2023
8 checks passed
@mhsdesign mhsdesign deleted the task/3594-behat-based-fusion-tests branch October 30, 2023 18:07
mhsdesign added a commit that referenced this pull request Oct 31, 2023
@mhsdesign
TASK: Fixup for pr #4641
9f7ee86
mhsdesign added a commit that referenced this pull request Nov 2, 2023
@mhsdesign
TASK: 2nd. Fixup for pr #4641 ContentCollection.feature
9515cbd
@mhsdesign mhsdesign mentioned this pull request Nov 2, 2023
Merged
6 tasks
kdambekalns added a commit that referenced this pull request Nov 2, 2023
@kdambekalns
Merge pull request #4686 from neos/task/fixContentCollectionFeature
a0d8ca0 
TASK: 2nd fixup for PR #4641 ContentCollection.feature
@mhsdesign mhsdesign mentioned this pull request Apr 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mficzel mficzel mficzel approved these changes

@mhsdesign mhsdesign mhsdesign approved these changes

Assignees
No one assigned
Labels
8.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bwaidelich @mficzel @mhsdesign