Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: 2nd fixup for PR #4641 ContentCollection.feature #4686

Merged
merged 1 commit into from Nov 2, 2023
Merged

TASK: 2nd fixup for PR #4641 ContentCollection.feature #4686

merged 1 commit into from Nov 2, 2023

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented Nov 2, 2023 •
edited by kdambekalns

see #4641

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

nezaniel
nezaniel approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@nezaniel nezaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for more meaningful exceptions

@kdambekalns kdambekalns changed the title TASK: 2nd. Fixup for pr #4641 ContentCollection.feature TASK: 2nd fixup for PR #4641 ContentCollection.feature Nov 2, 2023
kdambekalns
kdambekalns approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@kdambekalns kdambekalns merged commit a0d8ca0 into 8.3 Nov 2, 2023
11 checks passed
@kdambekalns kdambekalns deleted the task/fixContentCollectionFeature branch November 2, 2023 15:03
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this pull request Nov 12, 2023
@mhsdesign
TASK: Fusion Behat Test Make Sure To Throw Runtime Exceptions
bee5f12 
Additional fix for neos#4686
@mhsdesign mhsdesign mentioned this pull request Nov 12, 2023
Merged
6 tasks
neos-bot pushed a commit to neos/neos that referenced this pull request Nov 19, 2023
@mhsdesign
TASK: Fusion Behat Test Make Sure To Throw Runtime Exceptions
af34bcf 
Additional fix for neos/neos-development-collection#4686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdambekalns kdambekalns kdambekalns approved these changes

@nezaniel nezaniel nezaniel approved these changes

@kitsunet kitsunet Awaiting requested review from kitsunet

@bwaidelich bwaidelich Awaiting requested review from bwaidelich

@dlubitz dlubitz Awaiting requested review from dlubitz

@mficzel mficzel Awaiting requested review from mficzel

Assignees
No one assigned
Labels
8.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhsdesign @kdambekalns @nezaniel