Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Fusion Behat Test Make Sure To Throw Runtime Exceptions #4743

Conversation

mhsdesign
Copy link
Member

Additional fix for #4686

Instead of manually declaring @exceptionHandler we set it automatically for the entry point ;) This will help us detect exceptions which would otherwise be absorbed.

Dont worry, this is only temporary and not at all needed with neos 9

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@mhsdesign mhsdesign marked this pull request as ready for review November 12, 2023 19:54
@mhsdesign mhsdesign merged commit 1429260 into neos:8.3 Nov 19, 2023
6 checks passed
@mhsdesign mhsdesign deleted the task/fusionBehatTestMakeSureToThrowRuntimeExceptions branch November 19, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants