!!! TASK: Remove Node::nodeType

[mhsdesign]

Requires #5020 in the long term

With #4466 the fallback NodeType handling was removed from the core NodeType manager and extracted to Neos. See the trait NodeTypeWithFallbackProvider.
That required to make the nodeType field nullable on the NodeType.

This pr takes it a bit further by fully removing the attached NodeType schema from the Node.
The Node attached NodeType was declared as deprecated with Neos9-Beta10.

Resolves: #5019

Upgrade instructions

In Fusion accessing the NodeType via ${node.nodeType} wont work longer but one can leverage the helper ${Neos.Node.getNodeType(node)} to access the NodeType.

To get the NodeType for a Node in PHP, one can either use the Node::nodeTypeName and ask the Neos\ContentRepository\Core\NodeType\NodeTypeManager::getNodeType:

+ $nodeTypeManager->getNodeType($node->nodeTypeName);
- $node->nodeType;

For just accessing the string of the NodeType name you can consult the Node directly:

- $node->getNodeType()->getName();
+ $node->nodeTypeName->value;

Also note that getNodeType was made nullable by removing the default fallback. change
To restore this behaviour you can use the Neos\Neos\Utility\NodeTypeWithFallbackProvider trait which will return a NodeType instance for any Node considering the Fallback (the Neos.Neos:FallbackNode) in case the requested NodeType was removed. Please note that this behaviour is discouraged in favour of using nullable NodeTypes:

+ #[Flow\Inject]
+ protected ContentRepositoryRegistry $contentRepositoryRegistry;
+
+ use NodeTypeWithFallbackProvider;
+
+ $this->getNodeType($node);
- $node->nodeType;

Review instructions

Followup node.nodeType viewhelper for fluid (see also #5023)
Rector migrations will be provided as part of neos/rector#57

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[bwaidelich]

This is great, thanks for taking care!

But since this is a breaking change that will affect most installations, we should make sure that we have

• A proper description with explanations on how to migrate code
• Rector migration for Fusion code
• Rector migration for PHP code

And IMO we should have those in place before we merge this one – at least the first one :)

[kitsunet]

Yep, all according to plan!

[pKallert]

The nodetype is also still used in https://github.com/neos/neos-development-collection/blob/9.0/Neos.Neos/Tests/Functional/Fusion/NodeHelperTest.php#L93.
I am not sure if this is relevant here, since the tests seem to run through? Could at least be worth looking at :)

[mhsdesign]

Thanks for your throughout review @pKallert the NodeHelperTest must be rewritten to behat at some point see comment:

Skipped. Either migrate to behat or find a better way to mock node read models. See #4317

[pKallert]

Looks good!