!!! FEATURE: NodeTypeManager remove NodeType fallback handling

[nezaniel]

This moves node type fallback handling from the CR to the outer applications, e.g. Neos.

!!! Nodes now have an optional node type which is null if the NodeTypeName is not known to the NodeTypeManager.

Neos has been adjusted to

• ask the NodeTypeManager for the node type
• deal with NodeTypeNotFound itself by applying fallback to Neos.Neos:Fallback

For 3rd party applications relying on fallback NodeTypes, there now is the Neos\Neos\Utility\NodeTypeWithFallbackProvider trait available

Related: #4447

Checklist

• Code follows the PSR-12 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[mhsdesign]

THANK YOU SO MUCH for this quick implementation.

I did a full visual review - it was a little harder because you also adjusted more code to use the NodeTypeNameFactory and avoid now magic strings like 'Neos.Neos:Document' but thank you for that as well.

I have a few points to discuss left - but overall i approve mostly already ;)

[dlubitz]

Looks good to me by reading! Thank you

[mhsdesign]

Thanks for adjusting to the feedback from the weekly.

But i think we misunderstood each other about the traits.
With 364a230 you added the ContentRepositoryRegistryProvider and i think you wanted to implement bastians suggestion, but this would require an abstract method getContentRepositoryById.

Instead i propose to delay this discussion - or do nothing fancy here at all and just import the ContentRepositoryRegistry directly in the NodeTypeWithFallbackProvider as prefixed variable.

This pattern - while not especially pretty - has already been used across the codebase and we might just as well do it here too before blocking this pr any longer with this discussion.

Edit: i just found out that phpstan will perfectly analyze the traits, so we only have to use the property in the trait and declare it at another place: https://phpstan.org/blog/how-phpstan-analyses-traits

I implemented the suggestion here - feel free to merge it into this pr: :D
#4559

[mhsdesign]

The neos ui has to be adjusted as well. I removed the Headline nodeType from the demo site to test the fallback but the whole request fails (in the neos backend):

Call to a member function isOfType() on null

Exception Code | 0
-- | --
Error
Data/Temporary/Development/Cache/Code/Flow_Object_Classes/Neos_Neos_Ui_ContentRepository_Service_WorkspaceService.php
210
Packages/Application/Neos.Neos.Ui/Classes/ContentRepository/Service/WorkspaceService.php

This seems to be tested nowhere as the Neos Ui e2e tests pass and the neos ui has no phpstan 😢

Also the fusion rendering in the frontend is not really successful after removing the Headline

Im not sure, but this is not the behavior of Neos 8.x -> the node should just be not rendered.

thats because we access the nodeType in fusion:

the content case needs to be adjusted to (or do we actually need a better way of getting the nodes nodetype in fusion?)

prototype(Neos.Neos:ContentCase) < prototype(Neos.Fusion:Case) {
  default {
    @position = 'end'
    condition = true
    type = ${node.nodeType.name || "Neos.Neos:FallbackNode"}
  }
}

[mhsdesign]

I think we’ll need a NodeType for node helper for eel aswell? ${Neos.Node.getNodeType(node)}

im not sure how we handle node.nodeType is the use deprecated? Should we migrate Fusion already? And for how long is it guaranteed that the node knows it’s nodeType if fetched via the official ways - until Neos 10 and the well remove it?

Those questions need to be answered so that our users now what to expect and we know when to deprecate/remove it.

[bwaidelich]

Makes a lot of sense to me, I just wonder about the changed linter rules

[mhsdesign]

In combination with neos/neos-ui#3632 the neos ui e2e tests succeed locally